[TLM] Add custom types to docstrings #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ulya-tkch I unfortunately don't find the new descriptions super clear either. Perhaps you could first explain everything as if it were just floats or list of floats. And then later in the docstring say: Actually instead of float, this may be a Will leave reviews of this to @jas2600 But encourage you to write as simply and clearly as you can. |
|
MAX_PROMPT_LENGTH_TOKENS needs to be increased for TLM unit tests to start passing again. |
jas2600
approved these changes
Aug 30, 2024
Co-authored-by: Jay Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow our custom defined types to show up on help.cleanlab.ai here